Fix 500 error when viewing questions with solutions from deleted users #6561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user who marked an answer as a solution is later deleted, viewing the question was causing a 500 error. This occurred because the Question.solver property tried to retrieve the user from the solver_id metadata but failed since the user no longer exists in the database. The fix adds error handling in the Question.solver property to gracefully return None when User.DoesNotExist is raised, which is properly handled by the template's existing conditional checks. Steps to reproduce the fixed issue: 1. User A submits a question 2. User B leaves a reply 3. User A marks User B's reply as solution 4. Delete User A 5. Navigate back to the question (previously 500 error, now works properly)
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a 500 error that occurs when viewing questions solved by a deleted user by adding error handling in the Question.solver property.
- Adds a try/except block to catch User.DoesNotExist when retrieving the solver.
- Ensures that a missing user returns None to be properly handled by the template.
akatsoulas
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user who marked an answer as a solution is later deleted, viewing the question was causing a 500 error. This occurred because the Question.solver property tried to retrieve the user from the solver_id metadata but failed since the user no longer exists in the database.
The fix adds error handling in the Question.solver property to gracefully return None when User.DoesNotExist is raised, which is properly handled by the template's existing conditional checks.
Steps to reproduce the fixed issue: